Switch back to XR Plugin #484
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to try and get the XR plugin working. Currently, shadows are wrong and the order of execution of command buffers is flipped between eyes. This situation also causes lots of crashes (and a particular one 100% reproducible that happens when looking at GD after waking up).
We managed to reproduce these crashes and visual glitches by using the projection matrix coming from SteamVR instead of the one that the legacy VR plugin uses, so this has probably something to do with the projection matrix used by the XR plugin.
This PR is the only known way to avoid using the external patcher (although it might still be necessary to solve the performance issues in the ending credits) and to allow changing the mirrored eye without introducing an additional spectator camera (#458) .